sumthing not working here

**GregT** · December 24th, 2002, 16:07

Code:

sub uptime {

unless($^O =~ m/^Win32$/i) {

open(UPTIME, "</proc/uptime") || die "Couldn't open /proc/uptime for reading!\n";
$uptime = <UPTIME>;
close(UPTIME);

$uptimemin = $uptime/60%60;
$uptimehour = $uptime/3600%24;
$uptimeday = $uptime/86400;
@uptimeday = split(/./, $uptimeday);
$uptimeday = $uptimeday[0]; #give it a nicer name !

if($uptimeday gt "0") {

print "Server up for $uptimeday day\(s\), $uptimehour hour\(s\), and $uptimemin minute\(s\)\n";

} else {

print "Server up for $uptimehour hour\(s\) and $uptimemin minute\(s\)\n";

is leaving $uptimeday[0] blank ! whats wrong ?

**Dusty** · December 24th, 2002, 16:37

@uptimeday=split(/./,$uptimeday);

Do you mean /\./ (a period) instead of /./ (any character except a newline)?

if($uptimeday gt "0") {

If $uptimeday is a number, then you should use "if($uptimeday>0){".

print "... day$s$ ...

You don't need to escape that, "day(s)" is fine. Same for hour and minute.

You're also missing three curly brackets at the end, but I'll assume you just didn't copy them and they are actually there.

Also, while there isn't anything wrong with:

@uptimeday = split(/\./, $uptimeday);
$uptimeday = $uptimeday[0]; #give it a nicer name !

It is a bit much for such a simple task. It would be easier to use:

$uptimeday=~s/\..*//;

Or just cast it as an integer:

$uptimeday=int($uptimeday);

Unless you're going to use the decimal you truncate off later in the program, I wouldn't waste the memory storing it.